fix url loader bug with querysrtings #547

[revolunet]

check if image is http(s) based then removed the eventual querystring before checking file extension

[rubik]

Well I thought that if there was another ? before the one you want to split urlparse threw an error, but it actually parses it wrong. So sorry for bothering with useless things.

[revolunet]

i think this is not possible :/

[hansent]

at least a correct url I think should only have one "?". but in general I don't think extension is guranteed to be there the way you think

Actually I have in the past used the fact that I can add extra query args to fake an extension for kivy. e.g.:
image is served dynamically at:
http://example.com/images/dynamic?w-100&h=100
so I can do:
http://example.com/images/dynamic?w-100&h=100&fake_ext=.png
and kivy will load is as png...

I think correct way is to look at or infer mimetype?

[revolunet]

Yes extensions never guarantee anything;

We could also check mimetype if extension is not detected but thats another check, which need to read the response prior to load the correct loader.