Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carousel: make 'Carousel.remove_widget()' not cause 'IndexError' #6372

Merged
merged 2 commits into from
Jun 8, 2019
Merged

Carousel: make 'Carousel.remove_widget()' not cause 'IndexError' #6372

merged 2 commits into from
Jun 8, 2019

Conversation

gottadiveintopython
Copy link
Member

fix #6370

matham
matham requested changes Jun 7, 2019
View reviewed changes
Copy link
Member

@matham matham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can you please name your PR titles better (e.g. similar to how you name the issues)? That's because when compiling release notes we get the list of PR titles, so having a clear title would help there.

Thanks for your work!

kivy/tests/test_uix_carousel.py Outdated Show resolved Hide resolved
@gottadiveintopython gottadiveintopython changed the title Fix #6370 make 'Carousel.remove_widget()' not cause 'IndexError' Jun 8, 2019
@matham matham merged commit 9e7afcd into kivy:master Jun 8, 2019
@gottadiveintopython gottadiveintopython deleted the fix_6370 branch May 8, 2020 04:24
@matham matham added this to the 2.0.0 milestone Oct 28, 2020
@matham matham changed the title make 'Carousel.remove_widget()' not cause 'IndexError' Carousel: make 'Carousel.remove_widget()' not cause 'IndexError' Nov 14, 2020
@matham matham added the Component: Widgets kivy/uix, style.kv label Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matham matham matham approved these changes

Assignees
No one assigned
Labels
Component: Widgets kivy/uix, style.kv
Projects
None yet
Milestone
2.0.0
2 participants
@gottadiveintopython @matham