EventDispatcher: Move __self__ from widget to EventDispatcher and fix tests.
#6448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change should probably be listed in #5560 as it breaks our current code around adding a ScreenManager to any other widget. |
|
But how is it an API break? Moving to a superclass should not be an API break? |
|
I will investigate this some more. It came up in git bisect. Maybe it is coincidence. |
matham
changed the title
__self__ from widget to EventDispatcher and fix tests.__self__ from widget to EventDispatcher and fix tests.
matham
added
the
Component: core-widget
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that
proxy_refis now inEventDispatcher, it's helpful to also move__self__to it so we can get the actual object.Also adds memory leaks tests making sure the app is gc'd after each test is done, and fixes the often failing network test to not fail due to lack of internet.