Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphics: Change filename to source #6467

Merged
merged 3 commits into from
Sep 13, 2019
Merged

Conversation

crigaut
Copy link
Contributor

@crigaut crigaut commented Aug 13, 2019

Fixes #6360
Changes parameter, property and attribute filename to source to be consistent with the image module: https://kivy.org/doc/stable/api-kivy.uix.image.html

Copy link
Member

@inclement inclement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, code changes look fine, there's just the issue of it being a breaking change. It sounds like we'll be okay with that for Kivy 2.0, but I'll leave it for someone more familiar with the svg code to merge.

@matham matham added the Notes: API-break API was broken with backwards incompatibality label Aug 18, 2019
Copy link
Member

@tshirtman tshirtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this change, if needed it's easy to add an alias for compatibility, but this is an easy to fix update anyway, we just need to announce it as part of the breaking changes.

@tshirtman tshirtman merged commit 29dfcbc into kivy:master Sep 13, 2019
tshirtman pushed a commit that referenced this pull request Apr 26, 2020
@matham matham added this to the 2.0.0 milestone Oct 28, 2020
@matham matham changed the title Svg consistency Graphics: Svg consistency Dec 8, 2020
@matham matham changed the title Graphics: Svg consistency Graphics: Fix svg consistency Dec 8, 2020
@matham matham changed the title Graphics: Fix svg consistency Graphics: Change filename to source Dec 8, 2020
@matham matham added the Component: graphics kivy/graphics label Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: graphics kivy/graphics Notes: API-break API was broken with backwards incompatibality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistency issue
4 participants