Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text: Revert "Fixes multiline label w/ line_height < 1" #6507

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

tito
Copy link
Member

@tito tito commented Sep 8, 2019

Reverts #6422

This PR introduce issue with normal text rendering. See the attached screenshot on one app with and without it. I have the same behavior on Linux and Android. (be sure to open the original)

kivy-issue-6422

I suggest to remove to fix the normal text rendering, and find the right way to fix the issue in the meantime. The Kivy version pinned P4A include this issue.

Copy link
Member

@matham matham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Although I didn't understand originally how that fix was related to the specific issue of line height so maybe I'm missing something.

@matham matham merged commit 90b3174 into master Sep 9, 2019
@matham matham deleted the revert-6422-fix-line_height branch September 9, 2019 01:47
@matham matham added this to the 2.0.0 milestone Oct 28, 2020
@matham matham changed the title Revert "Fixes multiline label w/ line_height < 1" Text: Revert "Fixes multiline label w/ line_height < 1" Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants