Config: fix erroneous check of KIVY_NO_ENV_CONFIG #6540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines. |
fluxrider
referenced
this pull request
Sep 27, 2019
matham
requested changes
Sep 28, 2019
kivy/config.py
Outdated
| @@ -906,7 +906,7 @@ def name(self, value): | |||
| Logger.exception('Core: Error while saving default config file') | |||
|
|
|||
| # Load configuration from env | |||
| if environ.get('KIVY_NO_ENV_CONFIG', '0') != '0': | |||
| if environ.get('KIVY_NO_ENV_CONFIG', '0') == '0': | |||
There was a problem hiding this comment.
It should actually be if environ.get('KIVY_NO_ENV_CONFIG', '0') != '1':, because if it's empty it shouldn't disable it. Only if it's explicitly 1 should it be disabled.
There was a problem hiding this comment.
Yes, that's alright. I went the C style if not zero then it's set, but it would allow people to be sloppy (a bit like how it was before by just checking if the variable existing in env instead of checking the value). Cheers.
tito
approved these changes
Sep 28, 2019
matham
approved these changes
Sep 28, 2019
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
Thanks, it's always fun to contribute even if it's very small patch like this one. |
matham
changed the title
matham
added
the
Component: core-app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check to see if KIVY_NO_ENV_CONFIG is set was incorrect.
Without this fix, one has to set os.environ["KIVY_NO_ENV_CONFIG"] = "1" to be able to use KCFG_KIVY_LOG_LEVEL=warning and the likes. Which is the opposite of what config.py's doc says.