TreeViewNode: Fix arrow pos and size #6574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The arrow in the file chooser is too big and in a wrong position when used with a mobile. For full details see [here](https://groups.google.com/forum/#!msg/kivy-users/1bSCsywt2xA/o6F4prAhEAAJ)
|
Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines. |
|
Current code screenshots message Current code with out the
|
noembryo
commented
Oct 28, 2019
| @@ -335,7 +335,7 @@ | |||
|
|
|||
| orientation: 'horizontal' | |||
| size_hint_y: None | |||
| height: '24dp' # '48dp' if dp(1) > 1 else '24dp' | |||
There was a problem hiding this comment.
Too narrow on mobile
noembryo
commented
Oct 28, 2019
| @@ -235,8 +235,8 @@ | |||
| rgba: 1, 1, 1, int(not self.is_leaf) | |||
| Rectangle: | |||
| source: 'atlas://data/images/defaulttheme/tree_%s' % ('opened' if self.is_open else 'closed') | |||
| size: self.height / 2.0, self.height / 2.0 | |||
| pos: self.x - dp(20), self.center_y - dp(8) | |||
There was a problem hiding this comment.
Off center positioning in mobile
noembryo
commented
Oct 28, 2019
| @@ -235,8 +235,8 @@ | |||
| rgba: 1, 1, 1, int(not self.is_leaf) | |||
| Rectangle: | |||
| source: 'atlas://data/images/defaulttheme/tree_%s' % ('opened' if self.is_open else 'closed') | |||
| size: self.height / 2.0, self.height / 2.0 | |||
There was a problem hiding this comment.
Size of arrow gets big if the row height increase in mobile (we must use big rows on mobile)
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
Works for me! @noembryo Nice. Thanks |
matham
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arrow in the file chooser is too big and in a wrong position when used with a mobile.
For full details see here.