Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the path attribute is set, the full path is duplicated. Here is an example:
https://github.com/kivy/kivy/blob/master/kivy/uix/filechooser.py#L615
Example of the problem
The problem is with join. See the example here:
Suggestions
First
self.selection = abspath(entry.path)
https://github.com/kivy/kivy/blob/master/kivy/uix/filechooser.py#L615
Second
https://github.com/kivy/kivy/blob/master/kivy/uix/filechooser.py#L690
self.path = abspath(self.path)
Information
I applied the second suggestion because I don't know if the first suggestion can break something. on Windows or MacOS. The first would be better for performance because the second is called more than once.