-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ScrollView: Add always_enable_overscroll property on scrollview #6678
Conversation
5c2ccac
to
367f4c1
Compare
Shouldn't this be True by default? Also, I think |
I figured making it True by default could be an unwanted change in behavior, and i tend to be conservative about these things, even if i think it's indeed a better default behavior, if you think it's good enough to allow people who don't want this behavior to disable it, then i'm fine with switching the default value. the "always" seems important to me as currently we have overscroll only in the specific situation where the content is big enough to allow scrolling, this just makes the behavior unconditonnal. Also, it did remind me that it's impossible to overscroll with the mousewheel currently, (and with this patch it's now possible… but only if the content is small enough to prevent normal scrolling 😬 😆) i think this should be changed and mouse scroll should work the same as touch scroll in that regard, any opinion? |
367f4c1
to
2c1f9df
Compare
Renamed the property, and enabled it by default, documented the fact that you should disable it to get the previous behavior back. |
99fca71
to
0ff84b5
Compare
0ff84b5
to
e98503a
Compare
Looks ok if you're happy with it!? |
:attr:`always_overscroll` is a | ||
:class:`~kivy.properties.BooleanProperty` and defaults to `True`. | ||
versionadded:: 2.0.0 | ||
The option was added and enabled by default, set to False to get the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tshirtman Shouldn't there be a new line before versionadded
tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, maybe, i'll add it along the unittest fix, good call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe docs won't be generated property without new line.
Also, better readability :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, and the ..
before was missing as well, good thing you mentioned it.
fix: #6665