DDSFile: ddsfile.py fix for string/bytes comparing for py3 #6729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I used `bytes.decode()`, that should work on py2 and py3 but on py2 it's probably string anyway. Comparing to `b'DDS '` could have also worked(?).
|
Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines. |
tshirtman
approved these changes
Feb 16, 2020
|
Congrats on merging your first pull request! 🎉🎉🎉 |
matham
changed the title
matham
added
the
Component: core-app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used
bytes.decode(), that should work on py2 and py3 but on py2 it's probably string anyway. Comparing tob'DDS 'could have also worked(?).