Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphics: Use GLES context when ES2 is forced #6844

Merged
merged 2 commits into from
Apr 29, 2020

Conversation

jakogut
Copy link
Contributor

@jakogut jakogut commented Apr 27, 2020

On the desktop, multiple context types are generally available,
including full OpenGL with core and compatibility contexts, in addition
to ES contexts.

Certain extensions, such as GL_OES_EGL_image_external require a GLES
context, but SDL2 defaults to a core or compatibility context when
available.

This patch forces a GLES context when ES2 is forced using KIVY_GRAPHICS.

On the desktop, multiple context types are generally available,
including full OpenGL with core and compatibility contexts, in addition
to ES contexts.

Certain extensions, such as GL_OES_EGL_image_external require a GLES
context, but SDL2 defaults to a core or compatibility context when
available.

This patch forces a GLES context when ES2 is forced using KIVY_GRAPHICS.
Copy link
Member

@matham matham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok!?

@matham matham merged commit 40fc630 into kivy:master Apr 29, 2020
matham added a commit that referenced this pull request Apr 29, 2020
@matham
Copy link
Member

matham commented Apr 29, 2020

I had to revert it: #6846.

@matham matham added this to the 2.0.0 milestone Oct 28, 2020
@matham matham changed the title Use GLES context when ES2 is forced Graphics: Use GLES context when ES2 is forced Dec 9, 2020
@matham matham added the Component: graphics kivy/graphics label Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: graphics kivy/graphics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants