VKeyboard: Fix key_background_color property not used #6879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines. |
|
indeed looks like it was unduly removed in 7b3b209, i guess removing it was "speeding up the loop" as it doesn't need to be applied every time, but it should be at least applied once, before the loop, can you move it up a couple lines? |
|
Sure :) |
|
It seems it did never exist for the active keys though .. not sure if this is intentional or not. Edit: It seems this has been removed in c0759f4 |
tshirtman
approved these changes
May 16, 2020
|
yes, in any case it seems that it has been wrong for a long time, thanks for the fix! |
|
Congrats on merging your first pull request! 🎉🎉🎉 |
matham
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to style the VKeyboard Widget I came across the key_background_color property that is also described in the docs.
It however wasn't used when rendering the keys. This PR tries to fix this and applies the color when drawing the keys.