ScrollView: Don't crash when scrollview's content is the same size #6942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matham
reviewed
Jun 14, 2020
tshirtman
force-pushed
the
fix_scrollview_crash
branch
from
7f996a9
to
3fc7bda
Compare
also remove test that prevents scrolling when size_hint is not None, that's not necessary. There is still something that prevent scrolling when the size is exactly the size of content, but that's rare enough if you don't set size_hint to 1 in the direction you are interested in.
tshirtman
force-pushed
the
fix_scrollview_crash
branch
from
3fc7bda
to
b76e6a6
Compare
matham
approved these changes
Jun 14, 2020
matham
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also remove test that prevents scrolling when size_hint is not None,
that's not necessary.
There is still something that prevent scrolling when the size is exactly
the size of content, but that's rare enough if you don't set size_hint
to 1 in the direction you are interested in.