Networking: User Agent and Cookies added to UrlRequest #7054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines. |
|
Thanks. Would it be too much to ask to please update the documentation to include example usage? i.e. the module doc string. Otherwise it might go unnoticed. Thanks |
|
I guess we could just merge it and add docs later, rather than let it rot. |
tshirtman
approved these changes
Oct 6, 2020
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
@ibrahimcetin Thanks! +1 |
|
Sorry, I couldn't add docs because my computer was in technical service. I will add it after I get my computer. |
|
That would be appreciated. Thanks |
matham
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added user agent and cookies to UrlRequest