-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSX: Generate Kivy.app on the CI #7080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OSX wheels and Kivy.app pass all tests now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a re-work of kivy-sdk-packager for osx so that we can generate a kivy bundle and dmg more incrementally and fixes a bunch of issues there that prevented it to work on the CI. You can see the full readme at https://github.com/kivy/kivy-sdk-packager/tree/master/osx.
With these changes we can now generate a Kivy.dmg for use in packaging. Additionally, we're now also testing the generated Kivy.dmg in a separate clean environment. The only test failure is with gstreamer, but that can be fixed later.
Finally, I also updated the osx docs to make it simpler and point directly to kivy-sdk-packager for more complete docs.
An unrelated issue is that osx wheels tests fail, but it doesn't fail for osx unittests that are built in place. It makes me wonder if the osx wheels are safe to use in a clean environment.