Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: Detect python verion and gracefully fail on unsupported version #7110

Merged
merged 2 commits into from
Sep 27, 2020
Merged

Makefile: Detect python verion and gracefully fail on unsupported version #7110

merged 2 commits into from
Sep 27, 2020

Conversation

akshayaurora
Copy link
Member

fixes #7109

@akshayaurora akshayaurora mentioned this pull request Sep 27, 2020
Closed
@akshayaurora
Copy link
Member Author

closing in support for #7111

@akshayaurora akshayaurora reopened this Sep 27, 2020
matham
matham requested changes Sep 27, 2020
View reviewed changes
Makefile Outdated Show resolved Hide resolved
akshayaurora added a commit that referenced this pull request Sep 27, 2020
@akshayaurora
require python version >=3.6
b407ae4 
 supplement pr to #7110
@akshayaurora akshayaurora mentioned this pull request Sep 27, 2020
Merged
@akshayaurora
Copy link
Member Author

akshayaurora commented Sep 27, 2020 •
edited
Loading

@matham made changes to makefile here and setup.cfg here #7112

matham
matham approved these changes Sep 27, 2020
View reviewed changes
Copy link
Member

@matham matham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but I didn't test).

@akshayaurora akshayaurora merged commit fbeac05 into master Sep 27, 2020
@akshayaurora akshayaurora deleted the make_pyver_check branch September 27, 2020 17:45
@matham matham mentioned this pull request Oct 16, 2020
Merged
@matham matham added this to the 2.0.0 milestone Oct 28, 2020
@matham matham changed the title Detect python verion and gracefully fail on unsupported ver. Makefile: Detect python verion and gracefully fail on unsupported version Dec 8, 2020
@matham matham added the Component: distribution Wheels, apt PPA, conda, end user install issues label Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matham matham matham approved these changes

Assignees
No one assigned
Labels
Component: distribution Wheels, apt PPA, conda, end user install issues
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Add a check for python version in make and gracefully exit rather than fail on python version 2.
2 participants
@akshayaurora @matham