Tests: Ensure Bubble uses it's superclass's valid private API #7203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer merge checklist
Component: xxx
label.api-deprecation
orapi-break
label.release-highlight
label to be highlighted in release notes.versionadded
,versionchanged
as needed.Problem
Bubble currently overwrites some of GridLayout's internal properties:
_fills_row_first
,_fills_from_left_to_right
and_fills_from_top_to_bottom
. If any of them are renamed/removed, Bubble's should be renamed/removed as well. The problem is that the unittests don't say anything about this. So if someone only modifies GridLayout's, and forgot to modify Bubble's, Bubble might silently get broken.What this PR does
This PR lets the unittests check if those properties actually exist in Bubble's super classes.
(I feel like there is a better way to solve the problem, so I put "WIP" in the title.)