Doc: Add negative size warning #7286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines. |
matham
requested changes
Dec 27, 2020
kivy/uix/widget.py
Outdated
Comment on lines
1056
to
1062
|
|
||
| .. warning:: | ||
| Kivy allows the `width` property to be negative, but Kivy does not | ||
| support negative sizes. It is recommended to always have a positive | ||
| `width` property. If not, the programmer must account for the | ||
| consequences of a negative `width`. For example, `right` will actually | ||
| be left of `x` when `width` is negative. |
There was a problem hiding this comment.
Suggested change
| .. warning:: | |
| Kivy allows the `width` property to be negative, but Kivy does not | |
| support negative sizes. It is recommended to always have a positive | |
| `width` property. If not, the programmer must account for the | |
| consequences of a negative `width`. For example, `right` will actually | |
| be left of `x` when `width` is negative. | |
| .. warning:: | |
| A negative size is not supported. |
I think something very concise is better because we don't need say anything beyond it not being supported. And most people will not care much beyond that.
kivy/uix/widget.py
Outdated
Comment on lines
1075
to
1081
|
|
||
| .. warning:: | ||
| Kivy allows the `height` property to be negative, but Kivy does not | ||
| support negative sizes. It is recommended to always have a positive | ||
| `height` property. If not, the programmer must account for the | ||
| consequences of a negative `height`. For example, `top` will actually | ||
| be below of `y` when `height` is negative. |
There was a problem hiding this comment.
Suggested change
| .. warning:: | |
| Kivy allows the `height` property to be negative, but Kivy does not | |
| support negative sizes. It is recommended to always have a positive | |
| `height` property. If not, the programmer must account for the | |
| consequences of a negative `height`. For example, `top` will actually | |
| be below of `y` when `height` is negative. | |
| .. warning:: | |
| A negative size is not supported. |
matham
approved these changes
Dec 29, 2020
|
Congrats on merging your first pull request! 🎉🎉🎉 |
hamlet4401
pushed a commit
to tytgatlieven/kivy
that referenced
this pull request
Jul 3, 2021
* add negative size warning, fixes kivy#7226 * simplify warnings Co-authored-by: Guyrandy Jean-Gilles <->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7226. I'm leaving the maintainer checklist below but I don't think most of it is relevant.
Maintainer merge checklist
Component: xxxlabel.api-deprecationorapi-breaklabel.release-highlightlabel to be highlighted in release notes.versionadded,versionchangedas needed.