New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added documentation for RecycleView viewclass statefullness, including a warning, context paragraph, and minimal example #7328

Merged

matham merged 3 commits into kivy:master from stevewells20:doc-recycleview-viewclass-statefullness

Jan 27, 2021

Contributor

stevewells20 commented Jan 14, 2021

Maintainer merge checklist

Title is descriptive/clear for inclusion in release notes.
Applied a Component: xxx label.
Applied the api-deprecation or api-break label.
Applied the release-highlight label to be highlighted in release notes.
Added to the milestone version it was merged into.
Unittests are included in PR.
Properly documented, including versionadded, versionchanged as needed.


          Added documentation for RecycleView viewclass statefullness

0f38de7

welcome bot commented Jan 14, 2021

Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines.

matham requested changes

View reviewed changes

Member

matham left a comment

Just edited a little bit the wording and renamed some variables to make it more consistent with the rest of Kivy. Also fixed (hopefully) the pep8 issues.

kivy/uix/recycleview/__init__.py Outdated Show resolved Hide resolved

kivy/uix/recycleview/__init__.py Outdated Show resolved Hide resolved

kivy/uix/recycleview/__init__.py Outdated Show resolved Hide resolved

matham added 2 commits

January 27, 2021 12:19


          Apply suggestions from code review

bd7ff1c


          Fix PEP8 issues.

066c1b3

matham approved these changes

View reviewed changes

matham merged commit 3dee088 into kivy:master

welcome bot commented Jan 27, 2021

Congrats on merging your first pull request! 🎉🎉🎉

Contributor Author

stevewells20 commented Feb 1, 2021

Ah I walked away from GitHub after submitting this and forgot to check the status. Thank you for fixing my PR @matham!

stevewells20 deleted the doc-recycleview-viewclass-statefullness branch

February 1, 2021 22:05

stevewells20 mentioned this pull request

CheckBox in RecycleView viewclass appears to change state during window resize #7327

Closed

hamlet4401 pushed a commit to tytgatlieven/kivy that referenced this pull request


          Added documentation for RecycleView viewclass statefullness, includin…

5ae6052

…g a warning, context paragraph, and minimal example (kivy#7328)

* Added documentation for RecycleView viewclass statefullness

* Apply suggestions from code review

* Fix PEP8 issues.

Co-authored-by: matham <moiein2000@gmail.com>

matham added this to the 2.1.0 milestone

matham added the Component: documentation label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment