Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Add test commands to show missing coverage lines #7464

Merged
merged 3 commits into from
Apr 4, 2021

Conversation

Zen-CODE
Copy link
Member

@Zen-CODE Zen-CODE commented Apr 3, 2021

This PR just makes it easier to run tests produce coverage report the details the lines not covered by tests.

This last option is very useful for targeting tests so we can optimize efforts to up coverage.

Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

@Zen-CODE Zen-CODE changed the title 🚨 Add test commands for missing lines Add test commands for missing lines Apr 3, 2021
@Zen-CODE Zen-CODE changed the title Add test commands for missing lines [WIP] Add test commands for missing lines Apr 3, 2021
matham
matham previously approved these changes Apr 3, 2021
@Zen-CODE
Copy link
Member Author

Zen-CODE commented Apr 3, 2021

@tshirtman I went with this approach because if we change the default via [tool.pytest.ini_options] in pyproject.toml, the simple test report becomes too verbose. Simple is sometime all you want. So adding extra command for more detail seems better.

@Zen-CODE Zen-CODE changed the title [WIP] Add test commands for missing lines Add test commands for missing lines Apr 3, 2021
@Zen-CODE Zen-CODE merged commit a1ffd19 into master Apr 4, 2021
@Zen-CODE Zen-CODE deleted the extend_make_tests branch April 4, 2021 05:56
@matham matham changed the title Add test commands for missing lines Makefile: Add test commands to show missing coverage lines Apr 15, 2021
@matham matham added the Component: tests/CI Tests, CI, GitHub settings label Apr 15, 2021
@matham matham added this to the 2.1.0 milestone Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: tests/CI Tests, CI, GitHub settings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants