Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphicUnitTest: Add clear_window_and_event_loop method #7493

Merged
merged 1 commit into from
Jan 20, 2022
Merged

GraphicUnitTest: Add clear_window_and_event_loop method #7493

merged 1 commit into from
Jan 20, 2022

Conversation

pythonic64
Copy link
Contributor

Adds clear_window_and_event_loop method to GraphicUnitTest which clears Window.children, EventLoop.touches and event references from post processing.

This is an another possible fix to CI "random" failing tests, like the one reported here #7476 (comment).

Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

@pythonic64 pythonic64 added the Component: tests/CI Tests, CI, GitHub settings label Apr 23, 2021
@pythonic64 pythonic64 added this to the 2.1.0 milestone Apr 23, 2021
@pythonic64 pythonic64 force-pushed the update-add_method_clear_window_and_event_loop branch from d41b263 to a3a48b8 Compare May 4, 2021 15:13
matham
matham approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@matham matham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

@matham matham merged commit 3130818 into kivy:master Jan 20, 2022
@pythonic64 pythonic64 mentioned this pull request Feb 2, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matham matham matham approved these changes

Assignees
No one assigned
Labels
Component: tests/CI Tests, CI, GitHub settings
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pythonic64 @matham