Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventLoopBase: Start/stop event loop only once #7512

Merged
merged 1 commit into from
May 2, 2021
Merged

EventLoopBase: Start/stop event loop only once #7512

merged 1 commit into from
May 2, 2021

Conversation

pythonic64
Copy link
Contributor

Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

@pythonic64 pythonic64 added the Component: core-app app, clock, config, inspector, logger, resources, modules, clock, base.py label May 2, 2021
@pythonic64 pythonic64 added this to the 2.1.0 milestone May 2, 2021
@pythonic64 pythonic64 changed the title EventLoopBase: Start/stop event loop only once. EventLoopBase: Start/stop event loop only once May 2, 2021
matham
matham previously approved these changes May 2, 2021
View reviewed changes
Copy link
Member

@matham matham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This should make things more bullet proof.

@matham
Copy link
Member

matham commented May 2, 2021

The failing tests is due to the interaction between pyinstaller and pytest-cov. One of them must have updated and broke something.

@pythonic64
Copy link
Contributor Author

Can we not use pyinstaller development version https://github.com/kivy/kivy/blob/master/.ci/windows_ci.ps1#L91?

@matham
Copy link
Member

matham commented May 2, 2021

#7513 should resolve it. The issue is probably that the dev version I used had a problem.

@pythonic64
Copy link
Contributor Author

Ok. I'll rebase once #7513 gets merged.

@pythonic64 pythonic64 force-pushed the bugfix-start_stop_event_loop_only_once branch from 43291cc to 41c6c52 Compare May 2, 2021 18:53
@pythonic64 pythonic64 merged commit 570619f into kivy:master May 2, 2021
@pythonic64 pythonic64 mentioned this pull request Feb 2, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matham matham matham approved these changes

Assignees
No one assigned
Labels
Component: core-app app, clock, config, inspector, logger, resources, modules, clock, base.py
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pythonic64 @matham