Ellipse: update angle_start, angle_end to explicit floats #7860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ellipse parameters `angle_start` and `angle_end` are now called as `float` in docs instead of `int`
|
Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines. |
For additional clarity, change `angle_start` and `angle_end` default values to floats (0.0, 360.0)
seevee
changed the title
misl6
approved these changes
Aug 25, 2022
|
Congrats on merging your first pull request! 🎉🎉🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ellipse parameters
angle_startandangle_endare now called asfloatin docs instead ofintThis is effectively a typo fix, see the
cdefdefinitions directly below these changes:EDIT: additionally, the default values for these parameters have been explicitly set as floats for clarity.