-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [build wheel] Introduce TextInput provider (Android, iOS and "Legacy" Window provider) #8226
Open
misl6
wants to merge
15
commits into
kivy:master
Choose a base branch
from
misl6:feat/textinput-provider
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misl6
force-pushed
the
feat/textinput-provider
branch
from
April 29, 2023 19:48
a4a4c59
to
9cefc55
Compare
This was referenced Jun 4, 2023
misl6
force-pushed
the
feat/textinput-provider
branch
from
June 11, 2023 11:56
9cefc55
to
7500210
Compare
misl6
force-pushed
the
feat/textinput-provider
branch
2 times, most recently
from
June 25, 2023 14:56
e8ee360
to
442dd93
Compare
misl6
changed the title
[WIP] POC: Introduce TextInput provider (Android, iOS and "Legacy" Window provider)
[WIP] Introduce TextInput provider (Android, iOS and "Legacy" Window provider)
Jun 25, 2023
misl6
changed the title
[WIP] Introduce TextInput provider (Android, iOS and "Legacy" Window provider)
[WIP] [build wheel] Introduce TextInput provider (Android, iOS and "Legacy" Window provider)
Oct 1, 2023
misl6
force-pushed
the
feat/textinput-provider
branch
from
October 1, 2023 08:44
76b9696
to
43bf423
Compare
misl6
force-pushed
the
feat/textinput-provider
branch
from
October 21, 2023 13:04
d53c350
to
69bcee8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer merge checklist
Component: xxx
label.api-deprecation
orapi-break
label.release-highlight
label to be highlighted in release notes.versionadded
,versionchanged
as needed.A little brief
This is definitely not intended to be merged as-is, instead is just a POC for supporting additional textinput methods. (The idea is to treat the textinput provider as other core providers we have in Kivy (Camera, Window, ...))
It works (but sometimes it crashes, as I needed to achieve a result, and I did not took care about everything 😀) on both iOS and Android with platform-specific providers, and offers the same support as before with window-provider events on other platforms.
POC.mp4
Why this is needed?
Some related issues:
input_type
is set to "number" #8232TextInput
on android does not work withon_text_validate
method #8267How we tried to fix this issue in past:
TODO:
FocusBehavior
, possibly without breaking the current API. The keyboard needs (and should) be handled by the textinput provider.