Image: Fix stencil instructions leaking to user canvas.before/canvas instructions
#8276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misl6
approved these changes
Jun 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature introduced in this PR leaks stencil instructions to other user
canvas.before/canvasinstructions. Therefore, as discussed in Kivy's Discrod #dev channel, the most appropriate approach (taken in this PR) would be to limit the stencil instructions internally, preventing anything else drawn on the layers of the canvas from being clipped.Maintainer merge checklist
Component: xxxlabel.api-deprecationorapi-breaklabel.release-highlightlabel to be highlighted in release notes.versionadded,versionchangedas needed.