avplayer audio provider: Fixes seek and state on iOS and macOS
#8741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation was using playAtTime_, but 100% sure it was not working as playAtTime_ schedules the audio to play at a specific time, not to seek within the current audio file. To seek to a specific position in the audio, we should use the currentTime property of AVAudioPlayer. In addition, i added a delegate to correctly catch when the sound is stopping when reaching eof, which make the state property correctly work.
misl6
changed the title
avplayer audio provider: Fixes seek and state on iOS and macOS
misl6
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation was using playAtTime_, but 100% sure it was not working as playAtTime_ schedules the audio to play at a specific time, not to seek within the current audio file. To seek to a specific position in the audio, we should use the currentTime property of AVAudioPlayer.
In addition, i added a delegate to correctly catch when the sound is stopping when reaching eof, which make the state property correctly work.
Maintainer merge checklist
Component: xxxlabel.api-deprecationorapi-breaklabel.release-highlightlabel to be highlighted in release notes.versionadded,versionchangedas needed.