Added sms facade, example and android implementation #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ''' | ||
|
|
||
| def send(self, recipient, message): |
There was a problem hiding this comment.
I think we need to add some comments here so that it can appear in the doc. For example, we need to define that the recipient is a number and so on.
|
I think this PR is good to go. We just need to do some error checking the example code. Check if the recipient is a number and also add comments in facades.py so that it can be included in the plyer doc. |
|
Yep, it's good to merge, but additionnal documentation is needed |
tito
added a commit
that referenced
this pull request
Jun 24, 2014
Added sms facade, example and android implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.