Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sms facade, example and android implementation #52

Merged
merged 7 commits into from Jun 24, 2014

Conversation

Projects
None yet
3 participants
@mihaineacsu
Copy link
Contributor

commented Apr 13, 2014

No description provided.

'''

def send(self, recipient, message):

This comment has been minimized.

Copy link
@trivedigaurav

trivedigaurav May 22, 2014

Member

I think we need to add some comments here so that it can appear in the doc. For example, we need to define that the recipient is a number and so on.

@trivedigaurav

This comment has been minimized.

Copy link
Member

commented May 22, 2014

I think this PR is good to go. We just need to do some error checking the example code. Check if the recipient is a number and also add comments in facades.py so that it can be included in the plyer doc.

@tito

This comment has been minimized.

Copy link
Member

commented Jun 24, 2014

Yep, it's good to merge, but additionnal documentation is needed

tito added a commit that referenced this pull request Jun 24, 2014

Merge pull request #52 from mihaineacsu/sms
Added sms facade, example and android implementation

@tito tito merged commit 8f2a6b6 into kivy:master Jun 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.