Enabled transient notifications on Linux #639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Transient notifications (notifications that don't persist in the notifications list) are not programmable on Linux, even though they can be. The reason or this is because the
hint[s]
parameter required bynotify-send
anddbus
cannot be passed to the baseNotification.notify()
method.I've implemented a simple solution that allows the other keyword arguments to be passed to the
notify()
method, allowing the underlying_notify()
implementation to usehint[s]
and other notification arguments as required.Currently, trying to use hints with the
notify()
call fails:...even though the underlying
NotifyDBus
implementation clearly supports it:plyer/plyer/platforms/linux/notification.py
Line 35 in 0c226e1
With these changes, the transient notifications work as expected.
The
notify-send
implementation also did not support other arguments other than thetitle
and themessage
. I've added support forhint
,urgency
, etc., as supported by thenotify-send
binary itself: