Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚡ Fix pep8 violations #678

Merged
merged 2 commits into from
Apr 30, 2022
Merged

⚡ Fix pep8 violations #678

merged 2 commits into from
Apr 30, 2022

Conversation

Zen-CODE
Copy link
Member

Background

Another trivial PR to fix CICD checks for PR's that fail on this Pep8 check

Screenshot_2022-04-30_15-57-08

@misl6
Copy link
Member

misl6 commented Apr 30, 2022

Uh, seems now we have a F841 local variable 'sdcard' is assigned to but never used

@Zen-CODE Zen-CODE changed the title ⚡ Fix pep8 violations [WIP] ⚡ Fix pep8 violations Apr 30, 2022
misl6
misl6 approved these changes Apr 30, 2022
View reviewed changes
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Zen-CODE Zen-CODE changed the title [WIP] ⚡ Fix pep8 violations ⚡ Fix pep8 violations Apr 30, 2022
@Zen-CODE Zen-CODE closed this Apr 30, 2022
@Zen-CODE Zen-CODE reopened this Apr 30, 2022
@Zen-CODE Zen-CODE merged commit 43c4d28 into master Apr 30, 2022
@Zen-CODE Zen-CODE deleted the fix/CICD_checks_2 branch April 30, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misl6 misl6 misl6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zen-CODE @misl6