This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
Hotels: FIX height of separator in StarsPopup #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes MOBILE-4112. This was also not rendered correctly on iOS: some separators would be rendered with bigger height than others. My interpretation of this issue is that `0.5` is not consistently rendered on different screens with different screen densities. Using `StyleSheet.hairlineWidth` fixes this issue as it's optimised to always be a round number of pixels > This constant will always be a round number of pixels (so a line defined by it can look crisp) and will try to match the standard width of a thin line on the underlying platform https://facebook.github.io/react-native/docs/stylesheet#hairlinewidth
mrtnzlml
approved these changes
May 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes MOBILE-4112.
This was also not rendered correctly on iOS: some separators would be rendered with bigger height than others. My interpretation of this issue is that
0.5is not consistently rendered on different screens with different screen densities. UsingStyleSheet.hairlineWidthfixes this issue as it's optimised to always be a round number of pixelshttps://facebook.github.io/react-native/docs/stylesheet#hairlinewidth