Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotels: FIX height of separator in StarsPopup #1606

Merged
merged 1 commit into from May 6, 2019

Conversation

Projects
None yet
2 participants
@RobinCsl
Copy link
Collaborator

commented May 6, 2019

This fixes MOBILE-4112.

This was also not rendered correctly on iOS: some separators would be rendered with bigger height than others. My interpretation of this issue is that 0.5 is not consistently rendered on different screens with different screen densities. Using StyleSheet.hairlineWidth fixes this issue as it's optimised to always be a round number of pixels

This constant will always be a round number of pixels (so a line defined by it can look crisp) and will try to match the standard width of a thin line on the underlying platform

https://facebook.github.io/react-native/docs/stylesheet#hairlinewidth

Hotels: FIX height of separator in StarsPopup
This fixes MOBILE-4112.

This was also not rendered correctly on iOS: some separators would be rendered with bigger height than others. My interpretation of this issue is that `0.5` is not consistently rendered on different screens with different screen densities. Using `StyleSheet.hairlineWidth` fixes this issue as it's optimised to always be a round number of pixels
> This constant will always be a round number of pixels (so a line defined by it can look crisp) and will try to match the standard width of a thin line on the underlying platform

https://facebook.github.io/react-native/docs/stylesheet#hairlinewidth

@RobinCsl RobinCsl requested a review from mrtnzlml May 6, 2019

@RobinCsl RobinCsl requested a review from tbergq as a code owner May 6, 2019

@RobinCsl RobinCsl merged commit 1a8e109 into master May 6, 2019

1 check passed

ci/gitlab/stars-popup-separator-height Pipeline passed on GitLab
Details

@RobinCsl RobinCsl deleted the stars-popup-separator-height branch May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.