Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

Commit

Permalink
Shipit: add patch fixture for LFS
Browse files Browse the repository at this point in the history
We are currently not using it but I want to be sure it's fine in advance. Shipit does not support sync of these LFS files, however, we are about to use LFS only for Yarn offline mirror (maybe) and these files are not being synced to GitHub anyway so it's not needed (yet).

kiwicom-source-id: 2f03c55689b612f556a8104191debdc8378c8dd7
  • Loading branch information
Martin Zlámal authored and kiwicom-github-bot committed Jun 12, 2019
1 parent 63901ae commit 083d258
Show file tree
Hide file tree
Showing 3 changed files with 41 additions and 0 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ The only filter being applied when importing the projects is filter which moves
- our version is tailored for Kiwi.com needs and infra, not Facebook ones
- our version doesn't support [Mercurial](https://www.mercurial-scm.org/) and it's written in JS (not in Hack)
- our version doesn't support [Git Submodules](https://git-scm.com/book/en/v2/Git-Tools-Submodules)
- we _do not_ sync internal LFS storage with GitHub LFS (currently unused)
- we sync only master branches, other branches are not supported
- we currently cannot do this in one commit:
- changed Shipit config: https://github.com/facebook/fbshipit/commit/939949dc1369295c910772c6e8eccbbef2a2db7f
Expand Down
28 changes: 28 additions & 0 deletions src/__tests__/__snapshots__/parsePatch.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,34 @@ index b2a7546679fdf79ca0eb7bfbee1e1bb342487380..66bde67332bef8dfb2c70698c51bf37b
`;

exports[`matches expected output: lfs-removal.patch 1`] = `
~~~~~~~~~~ INPUT ~~~~~~~~~~
diff --git a/.yarn/cache/@kiwicom-js-0.9.0.tgz b/.yarn/cache/@kiwicom-js-0.9.0.tgz
deleted file mode 100644
index f2572f9c9d2f2ab4f2a61695a09ee50430f8ccbe..0000000000000000000000000000000000000000
--- a/.yarn/cache/@kiwicom-js-0.9.0.tgz
+++ /dev/null
@@ -1,3 +0,0 @@
-version https://git-lfs.github.com/spec/v1
-oid sha256:389a46fe92555e912f515578f718f546e58a0c9b81174a66068a35211d5e54ff
-size 4330
--
2.20.1 (Apple Git-117)
~~~~~~~~~~ OUTPUT ~~~~~~~~~~
diff --git a/.yarn/cache/@kiwicom-js-0.9.0.tgz b/.yarn/cache/@kiwicom-js-0.9.0.tgz
deleted file mode 100644
index f2572f9c9d2f2ab4f2a61695a09ee50430f8ccbe..0000000000000000000000000000000000000000
--- a/.yarn/cache/@kiwicom-js-0.9.0.tgz
+++ /dev/null
@@ -1,3 +0,0 @@
-version https://git-lfs.github.com/spec/v1
-oid sha256:389a46fe92555e912f515578f718f546e58a0c9b81174a66068a35211d5e54ff
-size 4330
`;

exports[`matches expected output: nasty.patch 1`] = `
~~~~~~~~~~ INPUT ~~~~~~~~~~
diff --git a/nasty.txt b/nasty.txt
Expand Down
12 changes: 12 additions & 0 deletions src/__tests__/fixtures/diffs/lfs-removal.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
diff --git a/.yarn/cache/@kiwicom-js-0.9.0.tgz b/.yarn/cache/@kiwicom-js-0.9.0.tgz
deleted file mode 100644
index f2572f9c9d2f2ab4f2a61695a09ee50430f8ccbe..0000000000000000000000000000000000000000
--- a/.yarn/cache/@kiwicom-js-0.9.0.tgz
+++ /dev/null
@@ -1,3 +0,0 @@
-version https://git-lfs.github.com/spec/v1
-oid sha256:389a46fe92555e912f515578f718f546e58a0c9b81174a66068a35211d5e54ff
-size 4330
--
2.20.1 (Apple Git-117)

0 comments on commit 083d258

Please sign in to comment.