Monorepo utils: add support for mismatched workspace dependencies

kiwicom-source-id: ff372801acf839d7a05f76936312205f190a75c2

src/__tests__/findRelatedWorkspaces.test.js

@@ -144,3 +144,78 @@ it("doesn't crash with circular dependencies - complex circle", () => {
     }
   `);
 });
+
+it('resolves mismatched workspace dependencies correctly', () => {
+  const circularWorkspaceDependencies = {
+    aaa: {
+      location: '',
+      workspaceDependencies: ['bbb'],
+      mismatchedWorkspaceDependencies: ['ccc'],
+    },
+    bbb: {
+      location: '',
+      workspaceDependencies: [],
+      mismatchedWorkspaceDependencies: [],
+    },
+    ccc: {
+      location: '',
+      workspaceDependencies: [],
+      mismatchedWorkspaceDependencies: [],
+    },
+  };
+
+  expect(findRelatedWorkspaces(circularWorkspaceDependencies, new Set(['aaa'])))
+    .toMatchInlineSnapshot(`
+    Set {
+      "aaa",
+    }
+  `);
+  expect(findRelatedWorkspaces(circularWorkspaceDependencies, new Set(['bbb'])))
+    .toMatchInlineSnapshot(`
+    Set {
+      "bbb",
+      "aaa",
+    }
+  `);
+  expect(findRelatedWorkspaces(circularWorkspaceDependencies, new Set(['ccc'])))
+    .toMatchInlineSnapshot(`
+    Set {
+      "ccc",
+      "aaa",
+    }
+  `);
+  expect(
+    findRelatedWorkspaces(
+      circularWorkspaceDependencies,
+      new Set(['aaa', 'ccc']),
+    ),
+  ).toMatchInlineSnapshot(`
+    Set {
+      "aaa",
+      "ccc",
+    }
+  `);
+  expect(
+    findRelatedWorkspaces(
+      circularWorkspaceDependencies,
+      new Set(['aaa', 'bbb']),
+    ),
+  ).toMatchInlineSnapshot(`
+    Set {
+      "aaa",
+      "bbb",
+    }
+  `);
+  expect(
+    findRelatedWorkspaces(
+      circularWorkspaceDependencies,
+      new Set(['aaa', 'bbb', 'ccc']),
+    ),
+  ).toMatchInlineSnapshot(`
+    Set {
+      "aaa",
+      "bbb",
+      "ccc",
+    }
+  `);
+});

src/findDirtyWorkspaces.js

@@ -9,7 +9,7 @@ import { type WorkspaceDependencies } from './Workspaces.flow';
 export default function findDirtyWorkspaces(
   workspaceDependencies: WorkspaceDependencies,
   changedFiles: $ReadOnlyArray<string>,
-) {
+): $ReadOnlySet<string> {
   const dirtyWorkspaces = new Set<string>();
   Object.keys(workspaceDependencies).forEach(dependencyName => {
     const value = workspaceDependencies[dependencyName];

src/findPathsToTest.js

@@ -12,7 +12,7 @@ import type { WorkspaceDependencies } from './Workspaces.flow';
 export default function findPathsToTest(
   workspaceDependencies: WorkspaceDependencies,
   changedFiles: $ReadOnlyArray<string>,
-) {
+): $ReadOnlySet<string> {
   const dirtyWorkspaces = findDirtyWorkspaces(
     workspaceDependencies,
     changedFiles,

src/findRelatedWorkspaces.js

@@ -15,8 +15,8 @@ import { type WorkspaceDependencies } from './Workspaces.flow';
  */
 export default function findRelatedWorkspaces(
   workspaceDependencies: WorkspaceDependencies,
-  touchedWorkspaces: Set<string>,
-) {
+  touchedWorkspaces: $ReadOnlySet<string>,
+): $ReadOnlySet<string> {
   const workspacesToTest = new Set<string>();
 
   (function unwind(touchedWorkspaces) {
@@ -36,6 +36,17 @@ export default function findRelatedWorkspaces(
             unwind([key]);
           }
         }
+
+        if (
+          workspaceDependencies[key].mismatchedWorkspaceDependencies.includes(
+            touchedWorkspace,
+          )
+        ) {
+          if (!workspacesToTest.has(key)) {
+            workspacesToTest.add(key);
+            unwind([key]);
+          }
+        }
       });
     });
   })(touchedWorkspaces);