Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a modifier to the Orbit Dialog. #379

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Add a modifier to the Orbit Dialog. #379

merged 2 commits into from
Mar 21, 2023

Conversation

yveskalume
Copy link
Contributor

Fixes #368

@yveskalume yveskalume requested a review from a team as a code owner March 21, 2023 10:20
hrach
hrach approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@hrach hrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the PR :)

@hrach hrach added bug Something isn't working accessibility labels Mar 21, 2023
@hrach hrach merged commit d9d4e12 into kiwicom:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrach hrach hrach approved these changes

Assignees
No one assigned
Labels
bug Something isn't working ui testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dialog is missing modifier for custom testTag, etc.
2 participants
@yveskalume @hrach