Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add capability to define default icon color for entire List #450

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Add capability to define default icon color for entire List #450

merged 1 commit into from
Jun 8, 2023

Conversation

shanio
Copy link
Contributor

@shanio shanio commented Jun 7, 2023 •
edited

@shanio shanio added the feature New feature or request label Jun 7, 2023
@shanio shanio self-assigned this Jun 7, 2023
@shanio shanio force-pushed the feature/list_icon_color_setup branch 2 times, most recently from 79ecb79 to 2d88826 Compare June 7, 2023 16:35
@shanio shanio marked this pull request as ready for review June 7, 2023 16:35
@shanio shanio requested a review from a team as a code owner June 7, 2023 16:35
@shanio shanio linked an issue Jun 7, 2023 that may be closed by this pull request
List: Make icon color a separate setup #269
Closed
@shanio shanio force-pushed the feature/list_icon_color_setup branch 2 times, most recently from fb0ed8c to 7c2c191 Compare June 7, 2023 17:44
hrach
hrach suggested changes Jun 8, 2023
View reviewed changes
ui/src/main/java/kiwi/orbit/compose/ui/controls/List.kt Outdated Show resolved Hide resolved
ui/src/main/java/kiwi/orbit/compose/ui/controls/List.kt Outdated Show resolved Hide resolved
ui/src/main/java/kiwi/orbit/compose/ui/controls/List.kt Outdated Show resolved Hide resolved
ui/src/main/java/kiwi/orbit/compose/ui/controls/List.kt Outdated Show resolved Hide resolved
ui/src/main/java/kiwi/orbit/compose/ui/controls/List.kt Outdated Show resolved Hide resolved
ui/src/main/java/kiwi/orbit/compose/ui/controls/List.kt Outdated Show resolved Hide resolved
ui/src/main/java/kiwi/orbit/compose/ui/controls/List.kt Outdated Show resolved Hide resolved
@hrach hrach added this to the Q2/2023 milestone Jun 8, 2023
@shanio shanio force-pushed the feature/list_icon_color_setup branch from 7c2c191 to 56b52f8 Compare June 8, 2023 13:26
@shanio shanio requested a review from hrach June 8, 2023 13:37
@hrach hrach changed the title Add capability to define default icon color for entire list Add capability to define default icon color for entire List Jun 8, 2023
@shanio shanio merged commit 67f5ed5 into main Jun 8, 2023
1 check passed
@shanio shanio deleted the feature/list_icon_color_setup branch June 8, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drekorian Drekorian Drekorian approved these changes

@hrach hrach hrach approved these changes

Assignees

@shanio shanio

Labels
feature New feature or request
Projects
None yet
Milestone
Q2/2023
Development

Successfully merging this pull request may close these issues.

List: Make icon color a separate setup
3 participants
@shanio @Drekorian @hrach