Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TextField's focus glow #566

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Add TextField's focus glow #566

merged 2 commits into from
Oct 31, 2023

Conversation

gerak-cz
Copy link
Contributor

closes #538

@gerak-cz gerak-cz requested a review from a team as a code owner October 26, 2023 12:54
@hrach hrach added the feature New feature or request label Oct 27, 2023
@hrach hrach changed the title Textfield focus glow Add TextField's focus glow Oct 27, 2023
@gerak-cz gerak-cz requested a review from hrach October 27, 2023 11:25
@gerak-cz gerak-cz requested a review from hrach October 30, 2023 09:29
hrach
hrach approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@hrach hrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last comment, otherwise LGTM.

ui/src/androidMain/kotlin/kiwi/orbit/compose/ui/controls/TextField.kt Outdated Show resolved Hide resolved
@gerak-cz gerak-cz merged commit 7dda34c into main Oct 31, 2023
1 check passed
@gerak-cz gerak-cz deleted the textfield-focus-glow branch October 31, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drekorian Drekorian Drekorian approved these changes

@hrach hrach hrach approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update TextFields to have the (focus) glow
3 participants
@gerak-cz @Drekorian @hrach