-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TextField's focus glow #566
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drekorian
approved these changes
Oct 27, 2023
2175bba
to
96b7d66
Compare
hrach
suggested changes
Oct 27, 2023
ui/src/androidMain/kotlin/kiwi/orbit/compose/ui/controls/TextField.kt
Outdated
Show resolved
Hide resolved
ui/src/androidMain/kotlin/kiwi/orbit/compose/ui/controls/TextField.kt
Outdated
Show resolved
Hide resolved
ui/src/androidMain/kotlin/kiwi/orbit/compose/ui/foundation/Shapes.kt
Outdated
Show resolved
Hide resolved
ui/src/androidMain/kotlin/kiwi/orbit/compose/ui/controls/TextField.kt
Outdated
Show resolved
Hide resolved
96b7d66
to
6c3d869
Compare
hrach
reviewed
Oct 27, 2023
ui/src/androidMain/kotlin/kiwi/orbit/compose/ui/controls/TextField.kt
Outdated
Show resolved
Hide resolved
ui/src/androidMain/kotlin/kiwi/orbit/compose/ui/controls/TextField.kt
Outdated
Show resolved
Hide resolved
ui/src/androidMain/kotlin/kiwi/orbit/compose/ui/controls/TextField.kt
Outdated
Show resolved
Hide resolved
ui/src/androidMain/kotlin/kiwi/orbit/compose/ui/controls/TextField.kt
Outdated
Show resolved
Hide resolved
ui/src/androidMain/kotlin/kiwi/orbit/compose/ui/foundation/Shapes.kt
Outdated
Show resolved
Hide resolved
6c3d869
to
e59e02a
Compare
e59e02a
to
09758d0
Compare
hrach
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last comment, otherwise LGTM.
ui/src/androidMain/kotlin/kiwi/orbit/compose/ui/controls/TextField.kt
Outdated
Show resolved
Hide resolved
09758d0
to
ed06148
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #538