-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(useLockScrolling): support nested scroll locks #3149
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +2.69 kB (+1%) Total Size: 477 kB
ℹ️ View Unchanged
|
silvenon
changed the title
fix(useLockScrolling): support more than one scroll locks
fix(useLockScrolling): support nested scroll locks
Oct 19, 2021
This fixes an issue where closing a nested Popover enables scrolling, instead of waiting for the parent Popover to close.
silvenon
force-pushed
the
fix/nested-popover-lock-scrolling
branch
from
October 19, 2021 19:40
c3878e8
to
8087bf4
Compare
mainframev
approved these changes
Oct 20, 2021
packages/orbit-components/src/hooks/useLockScrolling/lock-scrolling.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Victor Genaev <vgenaev@gmail.com>
silvenon
added a commit
that referenced
this pull request
Nov 2, 2021
Initialization of media queries is problematic because it's happening directly on render rather than as a side-effect. This can cause all sorts of issues, the most obvious being mismatched content during hydration because client already uses media queries for render its version. Another frustrating problem happened while testing locking scrolling with Cypress (#3149), if we're setting the viewport size _after_ visiting the test page rather than before, our test will behave unexpectedly because `useMediaQueryContext` already read the default full-width viewport size, not the new one, and it won't update after setting the viewport because mounting didn't happen yet, so no listeners have yet been attached. 😬 The media query logic was refactored because it was a bit hard to follow, and even circular because `useMediaQueryContext` was both consuming the context and providing value for it. Now all of this logic has been moved to a new provider component, which is a popular pattern to solve this kind of problems. BREAKING CHANGE: media queries in `useMediaQuery` are now being properly initialized, in `useEffect` rather than directly in render, which should prevent some cryptic bugs, but there is a tiny chance that it will break code for those who have been relying on previous behavior, so it's important to be aware of this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where closing a nested Popover enables scrolling, instead of waiting for the parent Popover to close.
This forks the
body-scroll-lock
library with a fix for willmcpo/body-scroll-lock#235 until I create a PR there.Storybook: https://orbit-silvenon-fix-nested-popover-lock-scrolling.surge.sh