UPDATE: ContactInput, NEW: Asterisk at label #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomashapl
force-pushed
the
support-formlabel-in-prefix
branch
3 times, most recently
from
9e28d09
to
395cfda
Compare
tomashapl
force-pushed
the
support-formlabel-in-prefix
branch
4 times, most recently
from
e952ab3
to
39a81cd
Compare
tomashapl
changed the title
vepor
reviewed
Sep 6, 2018
| @@ -4,6 +4,7 @@ export type Props = { | |||
| children: React$Node, | |||
| filled?: boolean, | |||
| disabled?: boolean, | |||
| required?: boolean, | |||
| }; | |||
There was a problem hiding this comment.
Should be typing for FormLabel strict too?
There was a problem hiding this comment.
I think it's not necessary, Why do you need this ?
There was a problem hiding this comment.
Because when someone will import FormLabel when needed to use compact InputField, then it's necessary to be strict in flow type, otherwise the person will be able to pass eg. className.
There was a problem hiding this comment.
I think if someone want to use FormLabel they should read documentation firstly how to use. If there will be more questions about this, we can update, so for now it is OK.
tomashapl
force-pushed
the
support-formlabel-in-prefix
branch
6 times, most recently
from
bb78172
to
b3002aa
Compare
vepor
force-pushed
the
support-formlabel-in-prefix
branch
from
b3002aa
to
1689086
Compare
tomashapl
force-pushed
the
support-formlabel-in-prefix
branch
from
1689086
to
3e8da13
Compare
vepor
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request meets the following criteria: