reviews: Retry Slack webhooks and add to Redis only when successful. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iakat
force-pushed
the
retry_slack_webhooks
branch
from
d5476e5
to
6e2091b
Compare
| @@ -77,7 +77,10 @@ def send_to_slack(self): | |||
| } | |||
|
|
|||
| for webhook_url in config.SLACK_WEBHOOK_URLS: | |||
| requests.post(webhook_url, json=body) | |||
| r = requests.post(webhook_url, json=body) | |||
There was a problem hiding this comment.
Might as well call it response in the actual code, don't you think? Especially since we already have an R.
|
Looks like you forgot to change the |
iakat
force-pushed
the
retry_slack_webhooks
branch
from
6e2091b
to
ff8f5bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11