Fix welcome page not ready if channel is invalid #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It checks if the first character is # that determines that is a channel, if it is not it doesn't allowing to connect. Closes kiwiirc#1310
Forgot ) at the end
E.g: #chan1,#chan2
prawnsalad
approved these changes
Jun 22, 2020
|
Oh, finally some fixes on that #1310 I was wondering about it just today. :-) |
|
Hmm, this is not entirely right though! when someone types in the channel area without the hashtag it should also allow the user to still join the channel, like in TheLunge Chat they have the same way even without the # it still joins a channel. Though I thought because Kiwi is written the same way with IRC-framework it should do the same. |
|
Of course, it will do for now, until there is another way round! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It checks if the first character is # that determines that is a channel, if it is not it doesn't allowing to connect.
Closes #1310