Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add invite user to channel in query sidebar #1374

Merged
merged 7 commits into from
Jun 14, 2023

Conversation

ItsOnlyBinary
Copy link
Collaborator

It could maybe look nicer but I'm unsure how to achieve that

closes #1372

@CoryChaplin
Copy link
Contributor

My feeling is that the UI would be better if the invitation was possible from the target channel, within a UI where you can search users that are in common channels. Maybe a complement to this.

@prawnsalad
Copy link
Member

/late @CoryChaplin yup that would make sense. @ItsOnlyBinary I guess the same type of thing in the channel sidebar but lists other users from the network? I can take over with the styling if needed once this part is in

@ItsOnlyBinary
Copy link
Collaborator Author

rebased

@ItsOnlyBinary ItsOnlyBinary merged commit fe4b0cc into kiwiirc:master Jun 14, 2023
1 check passed
@ItsOnlyBinary ItsOnlyBinary deleted the sidebar-query-invite branch June 14, 2023 17:18
CoryChaplin pushed a commit to CoryChaplin/kiwiirc-v2 that referenced this pull request Sep 3, 2023
* Add invite user to channel in query sidebar

* Add invite user to about buffer

* use ircClient.invite()

* cleanup SidebarAboutBuffer.vue

* Add translations for invitee, inviter, other

* Clear input after inviting user

* cleanup app.dev.po
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a 'Invite user to..' option in the query sidebar
3 participants