Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome: Use saved password #1381

Merged
merged 1 commit into from
Jan 3, 2021
Merged

Conversation

half-duplex
Copy link
Contributor

Kiwi already stores the network password in localStorage, let's not make the user retype it each time. This is particularly useful for embedded clients with a nontechnical audience, either on servers with a password or servers where the server password is automatically forwarded to NickServ.

Whether it's a good idea to store it at all without the user's explicit request is debatable but a different issue.

@prawnsalad
Copy link
Member

Nice, yea this would be handy. It should use the password from the options first as it currently does though, and then use the remembered password if that's empty.

@half-duplex
Copy link
Contributor Author

Hmm. Is there ever a reason for a user to use a password other than the options one? If not, that makes sense. If there is, maybe we could save the password only when it was modified? Though that would be confusing if it were accidentally modified...

@prawnsalad
Copy link
Member

If I connect to a network using options.password, it then gets remembered. If the password changes and updated in options.password, it would never use it again as it would continue using the remembered one.

As an admin configuring my webirc, the only reason I would pre-set a password in options.password is if I want that password to be used. The user could change the password in the UI if they wanted for some reason, but I'm not sure why you would want to given the webirc is telling you to use a pre-set.

@half-duplex
Copy link
Contributor Author

Updated to config > saved > empty

@prawnsalad prawnsalad merged commit 4aef965 into kiwiirc:master Jan 3, 2021
@prawnsalad
Copy link
Member

Sorry this took so long to review again, thanks!

@half-duplex half-duplex deleted the saved-password branch January 6, 2021 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants