Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send 'notification.enabled' event #1399

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Send 'notification.enabled' event #1399

merged 1 commit into from
Jul 23, 2020

Conversation

ItsOnlyBinary
Copy link
Collaborator

This allows plugins to use notifications without having to handle requesting permissions

@prawnsalad
Copy link
Member

In what case would notification.enabled be used in plugins? Plugins shouldn't need to request notification access as that's handled already and only at a certain point for which browsers trust the event, he first click after connected to a network

@prawnsalad prawnsalad merged commit f554bc8 into kiwiirc:master Jul 23, 2020
@ItsOnlyBinary ItsOnlyBinary deleted the notification-enabled branch July 23, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prawnsalad prawnsalad prawnsalad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ItsOnlyBinary @prawnsalad