Use Network name if there is one when creating new bnc-enabled network. #1431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When creating a new network with bouncer, the bouncer provider would always replace the network name with
Network1
,Network2
, etc.We may want to provide a better network name. E.g., when creating an IRC.com network in the app.
Solution:
With this PR, the BouncerProvider will give priority to the network name, if it exists, while making sure the network name is unique (as it used to).
For example, if the new network name is
MyNetwork
, the BouncerProvider will try the namesMyNetwork
,MyNetwork2
,MyNetwork3
, etc.If the network name is not set, the BouncerProvider will behave as preciously and try assigning the names
Network1
,Network2
,Network3
, etc.