Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Network name if there is one when creating new bnc-enabled network. #1431

Merged

Conversation

tralves
Copy link
Contributor

@tralves tralves commented Oct 23, 2020

Problem:
When creating a new network with bouncer, the bouncer provider would always replace the network name with Network1, Network2, etc.

We may want to provide a better network name. E.g., when creating an IRC.com network in the app.

Solution:
With this PR, the BouncerProvider will give priority to the network name, if it exists, while making sure the network name is unique (as it used to).
For example, if the new network name is MyNetwork, the BouncerProvider will try the names MyNetwork, MyNetwork2, MyNetwork3, etc.
If the network name is not set, the BouncerProvider will behave as preciously and try assigning the names Network1, Network2, Network3, etc.

@prawnsalad prawnsalad merged commit 9ef64c6 into kiwiirc:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants