Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statebrowser groups multiple fixes/improvements #1523

Merged
merged 4 commits into from
May 26, 2021
Merged

Statebrowser groups multiple fixes/improvements #1523

merged 4 commits into from
May 26, 2021

Conversation

ItsOnlyBinary
Copy link
Collaborator

@ItsOnlyBinary ItsOnlyBinary commented Apr 16, 2021 •
edited

  • Fix showing buffers other than channel/query eg *raw or *bnc
  • Don't show messages group when there are no queries
  • Add setting to enable/disable buffer groups

@ItsOnlyBinary
Copy link
Collaborator Author

@CoryChaplin maybe you want to review these changes ;)

CoryChaplin
CoryChaplin approved these changes Apr 17, 2021
View reviewed changes
Copy link
Contributor

@CoryChaplin CoryChaplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
For the log, maybe useful to give some examples of buffers that are not channels or queries ?

@ItsOnlyBinary ItsOnlyBinary merged commit 99af7a7 into kiwiirc:master May 26, 2021
@ItsOnlyBinary ItsOnlyBinary deleted the buffers_other branch May 26, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoryChaplin CoryChaplin CoryChaplin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ItsOnlyBinary @CoryChaplin