Restyle the 'close' button on the AppSettings section #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename appsettings title classname to something more fitting - Update classname in themes - restyle the element from a full width element to a smaller, more compact right aligned close button - Makes opening the appsettings section far less jaring to the user
AllanOcelot
added
the
Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restyles the 'close' heading on the appsettings to a smaller, more user friendly, right aligned button.
This has the benefit of swapping between the views far less ugly to the user, since the green 'kiwi bar' at the top of both views is consistently sized.
Before:
After:
There is a discussion to be had about changing the colour to something other than green, as the user would most likely be expecting an orange/red close button, but that's for another PR :)