Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all button elements have type attribute #1563

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

ItsOnlyBinary
Copy link
Collaborator

@ItsOnlyBinary ItsOnlyBinary commented Jul 13, 2021

in Firefox button elements without type attribute that are a child of <form> behave as a submit button

fix by ensuring all button elements have a type attribute defined

closes #1425

@ItsOnlyBinary ItsOnlyBinary merged commit 0893244 into kiwiirc:master Jul 15, 2021
@ItsOnlyBinary ItsOnlyBinary deleted the button-type branch July 15, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firefox in personal startup closes both connections when opening a second
1 participant