New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for nick change event in SelfUser to correctly show errors #1577

Merged

ItsOnlyBinary merged 2 commits into kiwiirc:master from ItsOnlyBinary:selfuser-nickchange

Aug 19, 2021

Collaborator

ItsOnlyBinary commented Jul 30, 2021 •

edited

closes #1401
closes #1575


          Wait for nick change event in SelfUser to correctly show errors

8145ef6

ItsOnlyBinary added the adds translations label

Collaborator Author

ItsOnlyBinary commented Jul 30, 2021

Add a loader to indicate something is happening
Add a timeout in case of unexpected event
Double check if the remove form was there for styling


          add a waiting state to InputPrompt.vue && add timeout to SelfUser.vue…

… nick change

ItsOnlyBinary merged commit 4e7a539 into kiwiirc:master

ItsOnlyBinary deleted the selfuser-nickchange branch

August 19, 2021 15:31

ItsOnlyBinary mentioned this pull request

SelfUser not possible to return from error #1136

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment