Update draft/chathistory implementation #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsOnlyBinary
force-pushed
the
chathistory-20220121
branch
from
4981205
to
628bcfe
Compare
ItsOnlyBinary
force-pushed
the
chathistory-20220121
branch
3 times, most recently
from
871d1ed
to
edb82c8
Compare
… query history requests
ItsOnlyBinary
force-pushed
the
chathistory-20220121
branch
from
99725c7
to
36e9492
Compare
CoryChaplin
pushed a commit
to CoryChaplin/kiwiirc-v2
that referenced
this pull request
Sep 3, 2023
* Update draft/chathistory implementation * Fix existing users check for scrollback * Use history.latest when requesting latest scrollback * Improve chathistory detection * Suppress invalid_target errors from chathistory * Always resolve on chathistory fail * Add "Loading previous messages..." translation * Queue chathistory requests so not to flood the server on connect with query history requests * use client.user.nick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this applies all needed changes yet, but it at least seems to get it working with unrealircd 6.0.1.1
Hopefully it also maintains backwards support
closes #1616