-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow sidebar in queries (single state) #781
Conversation
74eb34f
to
4c4b5c2
Compare
7b10b74
to
e8aefb0
Compare
Squashed and rebased |
e8aefb0
to
16aa826
Compare
rebased |
16aa826
to
d204642
Compare
Is it wanted to remove sidebar.toggle ? |
showSidebar() is unused from what i can tell. If thats what your referring to |
In sidebarstate.js line 28 this.listen(this.$state, 'sidebar.component', (component) => {
this.activeComponent = component;
this.sidebarOpen = !!component;
this.sidebarSection = '';
}); If |
d204642
to
f6473ef
Compare
I think the logic in SidebarState.js has become a little unwieldy with the changes it got over time which makes extending it a little awkward. It works as it is which is fine but I think we should draw out the logic for what it should actually do and how it decides what section to show and essentially re-write this files logic. The logic drawn out will also be documenting it for future as it's difficult to follow currently. Just waiting on confirmation that this works with plugins from elephantman before merging. |
@prawnsalad tested the latest version of this and it works well including with a sidebar inside queries coming from a plugin. |
closes #685
closes #818