Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sidebar in queries (single state) #781

Merged
merged 2 commits into from
Jun 19, 2020

Conversation

ItsOnlyBinary
Copy link
Collaborator

@ItsOnlyBinary ItsOnlyBinary commented Jan 14, 2019

closes #685
closes #818

@ItsOnlyBinary
Copy link
Collaborator Author

Squashed and rebased

@ItsOnlyBinary
Copy link
Collaborator Author

rebased

@CoryChaplin
Copy link
Contributor

Is it wanted to remove sidebar.toggle ?

@ItsOnlyBinary
Copy link
Collaborator Author

showSidebar() is unused from what i can tell. If thats what your referring to

src/components/SidebarState.vue Outdated Show resolved Hide resolved
src/components/SidebarState.vue Show resolved Hide resolved
src/components/SidebarState.vue Show resolved Hide resolved
@prawnsalad
Copy link
Member

In sidebarstate.js line 28

        this.listen(this.$state, 'sidebar.component', (component) => {
            this.activeComponent = component;
            this.sidebarOpen = !!component;
            this.sidebarSection = '';
        });

If component is truthy it could do with setting this.sidebarSection = 'component' so that it will stay open. Looking at the rest of the file it looks like that's all that's needed... I think

@prawnsalad
Copy link
Member

I think the logic in SidebarState.js has become a little unwieldy with the changes it got over time which makes extending it a little awkward. It works as it is which is fine but I think we should draw out the logic for what it should actually do and how it decides what section to show and essentially re-write this files logic. The logic drawn out will also be documenting it for future as it's difficult to follow currently.

Just waiting on confirmation that this works with plugins from elephantman before merging.

@CoryChaplin
Copy link
Contributor

@prawnsalad tested the latest version of this and it works well including with a sidebar inside queries coming from a plugin.
👍 from me and great work @ItsOnlyBinary !

@prawnsalad prawnsalad self-requested a review June 19, 2020 21:22
@prawnsalad prawnsalad merged commit ca14fe4 into kiwiirc:master Jun 19, 2020
@ItsOnlyBinary ItsOnlyBinary deleted the sidebar-queries-2 branch June 19, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] UserBox stays open when joining new channel show user sidebar in private messages
3 participants