-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api addUi userbox_button #973
api addUi userbox_button #973
Conversation
This adds an easy way to add plugin buttons to the userBox I take it? |
static/themes/common/base.css
Outdated
@@ -320,7 +320,8 @@ | |||
color: var(--brand-default-fg); | |||
} | |||
|
|||
.kiwi-userbox .kiwi-userbox-actions .kiwi-userbox-action:hover { | |||
.kiwi-userbox .kiwi-userbox-actions .kiwi-userbox-action:hover, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line can simply be .kiwi-userbox-action:hover,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been made less specific now
This could do with passing some props to the plugin like we do here https://github.com/kiwiirc/kiwiirc/blob/master/src/components/ControlInput.vue#L97 Passing |
7131a2a
to
dc8c09d
Compare
this doesnt appear to work with using data |
As a solution i propose we use:
this should help prevent any conflicts and also keep it consistent throughout the api.
|
Actually that makes sense, but I would use a
|
Note ive changed ControlInput.vue to match the others which will be a breaking change for anyone using the old props |
d798a41
to
06ffc01
Compare
rebased |
06ffc01
to
0d875af
Compare
0d875af
to
bb18d0e
Compare
rebased |
bb18d0e
to
7c51598
Compare
cc70af4
to
9ccf78b
Compare
9ccf78b
to
29c9a17
Compare
not sure if the css for this is going to need looking over by allan
Test plugin here: https://gist.github.com/ItsOnlyBinary/cb0b1d788b752485d093d1d20c92215b
closes #897